Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid] Styles are missing after the gulp build #6651

Open
DeltaCircuit opened this issue Nov 1, 2018 · 9 comments
Open

[Grid] Styles are missing after the gulp build #6651

DeltaCircuit opened this issue Nov 1, 2018 · 9 comments

Comments

@DeltaCircuit
Copy link

Steps

  • Install semantic ui 2.4.2 (npm i semantic-ui@latest)
  • Choose Automatic installation
  • Run gulp build from ./semantic folder

Expected Result

The ./dist/components folder should have grid.css as well as grid.min.css and the dist/semantic.css should have the CSS rule sets for the component Grid.

Actual Result

There's no grid.css in the dist/components/ folder and no CSS rule sets in dist/semantic.css

Version

2.4.2

@mcrawshaw
Copy link

mcrawshaw commented Nov 1, 2018

Probably 1/2 of the css is missing (accordion, card, checkbox, dimmer, etc).

Not caused by 2.4.2, as I need to rollback to 2.3.3 for this to work again. No idea what in 2.4.0 introduced this issue, nothing in the changelog seems gulp related.

Just noticing now because previously I was overriding previous dist output. So to replicate make sure you delete your dist folder 1st.

@DeltaCircuit
Copy link
Author

@mcrawshaw I made sure the dist directory was clean every time I ran build. Also, sorry for not mentioning the problem persists from 2.4.0. I tested with several versions and came to know that 2.3.x was the latest one working. But the issue template had only one placeholder for version, so I thought I'd mention the latest.

@mcrawshaw
Copy link

@giridharangm All good. Was trying to confirm your issue in more detail. Strange no one has picked it up already!

@ColinFrick
Copy link

Node version? OS?

This works on Linux / Node v11.0.0 with no problems:

mkdir test && cd test && npm init && npm install semantic-ui@latest && npx gulp --cwd semantic clean && npx gulp --cwd semantic build

@DeltaCircuit
Copy link
Author

@ColinFrick Windows 10 x64 w/ both Node V10 and V11.

Also, if it's a fresh install, then the installation hangs at creating LESS files step

@y0hami
Copy link
Member

y0hami commented Nov 2, 2018

@giridharangm I also had the hanging problem but I updated to Node 10 and it was fine. It is currently a known issue. #6641

@mcrawshaw
Copy link

Fresh install works for me. It was something in my semantic folder that was causing the issue. I'm having some trouble identifying why. I run on OSX and Ubuntu. Node 11. I do use yarn but the semantic installer was able to update my semantic folder fine. I'm going with a fresh install.

I've attached my semantic folder if anyone wishes to investigate further.

@hammy2899 not sure the headline issue has been confirmed as a bug yet.
semantic.zip

@DeltaCircuit
Copy link
Author

Tried on WSL. Installation went fine (with audit errors) built the css (with grid.css). So, I guess it's just limited to Windows? 🤷‍♂️

@peperoni321
Copy link

peperoni321 commented Mar 22, 2019

Issue related to Semantic-Org/Semantic-UI-LESS#53

There is missing
@placeholder: 'default';
in theme.config file
which causes gulp build failure which is unfortunately not handled (exception is not caught but ignored)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants