From 25e3f9983fcc2e260076617c1c30657c4ab4503d Mon Sep 17 00:00:00 2001 From: ChristianBusshoff Date: Thu, 21 Nov 2024 14:50:58 +0100 Subject: [PATCH] change Value to lowercase && disabled color-contrast rule in playwright --- .github/workflows/import-figma.yml | 2 +- packages/sit-onyx/.storybook/theme-switch.ts | 2 +- packages/sit-onyx/src/playwright/screenshots.tsx | 3 ++- packages/sit-onyx/src/styles/index.scss | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/import-figma.yml b/.github/workflows/import-figma.yml index 429bacd6c..167558444 100644 --- a/.github/workflows/import-figma.yml +++ b/.github/workflows/import-figma.yml @@ -27,7 +27,7 @@ jobs: # we need to separately import the themes because they are all needed in different formats and selectors - name: 🎨 Import onyx light variables run: | - pnpm run @sit-onyx/figma-utils import-variables -k "${{ vars.FIGMA_FILE_KEY }}" -t "${{ secrets.FIGMA_TOKEN }}" -d "../sit-onyx/src/styles/variables/themes" -m Value onyx-light -f CSS -s ":where(:root), .onyx-theme-default" + pnpm run @sit-onyx/figma-utils import-variables -k "${{ vars.FIGMA_FILE_KEY }}" -t "${{ secrets.FIGMA_TOKEN }}" -d "../sit-onyx/src/styles/variables/themes" -m value onyx-light -f CSS -s ":where(:root), .onyx-theme-default" working-directory: packages/figma-utils - name: 🎨 Import onyx dark variables run: | diff --git a/packages/sit-onyx/.storybook/theme-switch.ts b/packages/sit-onyx/.storybook/theme-switch.ts index 59cbd32af..cc3852c8c 100644 --- a/packages/sit-onyx/.storybook/theme-switch.ts +++ b/packages/sit-onyx/.storybook/theme-switch.ts @@ -29,7 +29,7 @@ export const onyxThemeGlobalType = { icon: "paintbrush", dynamicTitle: true, items: Object.keys(ONYX_THEMES) - .filter((key) => !key.includes("dark") && !key.includes("Value")) + .filter((key) => key.includes("light")) .map((theme, index) => ({ value: theme.replace("-light.css", ""), title: theme.replace("-light.css", ""), diff --git a/packages/sit-onyx/src/playwright/screenshots.tsx b/packages/sit-onyx/src/playwright/screenshots.tsx index 352ed0064..f0fd71638 100644 --- a/packages/sit-onyx/src/playwright/screenshots.tsx +++ b/packages/sit-onyx/src/playwright/screenshots.tsx @@ -82,8 +82,9 @@ export const executeMatrixScreenshotTest = async