Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should num_vels be the maximum or the first of the lengths of each ccf plan? #68

Open
hematthi opened this issue May 30, 2022 · 0 comments
Open

should num_vels be the maximum or the first of the lengths of each ccf plan? #68

hematthi opened this issue May 30, 2022 · 0 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@hematthi
Copy link
Collaborator

In calc_ccf_and_var_chunklist:

EchelleCCFs.jl/src/convenience/ccf_chunklist.jl

Line 82 in a639217

num_vels = maximum(map(chid->calc_length_ccf_v_grid(plan_for_chunk[chid]), 1:num_chunks ))

But in calc_ccf_chunklist! and calc_ccf_chunklist:

EchelleCCFs.jl/src/convenience/ccf_chunklist.jl

Line 23 in a639217

num_vels = calc_length_ccf_v_grid(first(plan_for_chunk))

EchelleCCFs.jl/src/convenience/ccf_chunklist.jl

Line 53 in a639217

num_vels = calc_length_ccf_v_grid(first(plan_for_chunk))

@hematthi hematthi added help wanted Extra attention is needed question Further information is requested labels May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hematthi