Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Specificity, Responsiveness, and Common Pitfalls Sections to CSS-in-JavaScript Style Guide #2

Open
Robbie-BOIII opened this issue Oct 11, 2024 · 5 comments

Comments

@Robbie-BOIII
Copy link
Owner

@GifftyCode cloned issue airbnb/javascript#3001 on 2024-06-24:

I propose adding the following sections to the Airbnb CSS-in-JavaScript Style Guide:

  1. Specificity:

    • Handling CSS specificity.

    • Avoiding the use of !important.

  2. Responsiveness:

    • Best practices for media queries.

    • Techniques for building responsive components.

  3. Common Pitfalls:

    • Common mistakes and how to avoid them.

    • Debugging tips for CSS-in-JavaScript issues.

These additions will provide valuable guidelines to help developers write more effective and maintainable styles.

Request:

I would like to contribute to the guide by drafting these sections. Please let me know if this aligns with the project’s goals and if I can proceed.

Thank you!

@Robbie-BOIII
Copy link
Owner Author

@shivansh84ya commented on 2024-07-11:

Could you assign this issue to me ??

@Robbie-BOIII
Copy link
Owner Author

@speedywarp commented on 2024-08-03:

Could you assign this issue to me ??

@shivansh84ya are you working on this issue?

@Robbie-BOIII
Copy link
Owner Author

@ljharb commented on 2024-08-04:

Issues don’t get assigned in open source - if there’s a linked PR, great, if not, feel free to file one.

@Robbie-BOIII
Copy link
Owner Author

@harsh0728 commented on 2024-09-18:

/attempt #3001

@Sandhya-Madhuri
Copy link

Hi @Robbie-BOIII I have added above sections to CSS-in-JavaScript Style Guide: readme file, please have a look at this pr airbnb/javascript#3052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants