Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tokens: Code Color Scheme #16

Open
bennypowers opened this issue Aug 10, 2022 · 15 comments · May be fixed by #57
Open

New Tokens: Code Color Scheme #16

bennypowers opened this issue Aug 10, 2022 · 15 comments · May be fixed by #57
Assignees
Labels
for design Design work is requested for dev

Comments

@bennypowers
Copy link
Member

We need a code syntax color scheme for prism, and alternatively for vim/v****e

@coreyvickery
Copy link
Collaborator

@bennypowers Does this refer to colors for syntax highlighting?

@bennypowers
Copy link
Member Author

yes, so we could use it for markdown highlighting, code playgrounds, snippets, and editor color themes, whathaveyou

@coreyvickery
Copy link
Collaborator

@bennypowers This is in progress, I am working with other design teams to try and unify one color scheme. It would be great to see examples of the things you need these values for even if they are quick screenshots.

@bennypowers
Copy link
Member Author

@bennypowers
Copy link
Member Author

I'd recommend starting by defining terminal ascii colours, for example this version of Catppuccin Mocha for Black Box terminal

from there we can then do a prism syntax theme, treesitter syntax theme (e.g. that same catppuccin theme for neovim)

@bennypowers bennypowers changed the title Code Color Scheme New Tokens: Code Color Scheme Sep 1, 2022
@bennypowers bennypowers added the for design Design work is requested label Sep 1, 2022
@bennypowers bennypowers moved this to Backlog in Red Hat Design System Sep 1, 2022
@bennypowers bennypowers moved this from Backlog to In Progress in Red Hat Design System Sep 1, 2022
@coreyvickery
Copy link
Collaborator

@bennypowers I think I can provide you with values because we are moving on to creating rh-code-block.

RedHat-UX/red-hat-design-system#328

@bennypowers bennypowers added this to the 1.0 milestone Sep 11, 2022
@bennypowers
Copy link
Member Author

I added this to 1.0 milestone, since it's WIP

@bennypowers
Copy link
Member Author

We need this for demo playgrounds as well (spin this out into a new issue later on)

@coreyvickery
Copy link
Collaborator

@bennypowers How would you like me to deliver this information to you? Do you need the hex color codes and token names? Anything else?

@bennypowers
Copy link
Member Author

yeah that should do. you're welcome to start a pr if you're interested

@coreyvickery coreyvickery moved this from In Progress to Review in Red Hat Design System Nov 3, 2022
@bennypowers bennypowers self-assigned this Nov 8, 2022
@bennypowers
Copy link
Member Author

Here are some token (by which i mean programming language token, not design token) names from prism.js, loosely sorted into three groups by order of importance

comment
property
keyword
tag
class-name
boolean
constant
punctuation
number
attr-name
string
symbol
variable
operator
attr-value
function
regex

namespace
deleted
selector
char
builtin
inserted
entity
url
atrule
important

prolog
doctype
cdata

I get the sense that if we assign token (design tokens) to these, that's pretty much job done.

TODO: demo codepen for Corey to muck about with, featuring:

  • HTML/JS/CSS
  • Bash
  • Markdown
  • Go
  • Rust
  • JSON
  • YAML

@bennypowers bennypowers linked a pull request Jan 26, 2023 that will close this issue
@coreyvickery
Copy link
Collaborator

@marionnegp Tagging you to take over.

@marionnegp marionnegp self-assigned this Feb 7, 2023
@coreyvickery
Copy link
Collaborator

@bennypowers @nikkimk Current colors, see screens 3 and 9.

https://xd.adobe.com/view/c4cc943e-618d-4fbe-8ab2-8e29fd135393-919f/

Let me know if you have specific questions about where to apply them.

@bennypowers
Copy link
Member Author

are those existing crayon colours?

@markcaron markcaron removed this from the RHDS Tokens 1.0 milestone Sep 15, 2023
@markcaron
Copy link
Contributor

Feel free to disagree, but as for the language support, I'd say...

Need first

  1. HTML/JS/CSS
  2. Bash
  3. Typescript
  4. Markdown
  5. JSON
  6. YAML

Next set

  1. PHP
  2. Python
  3. Java
  4. Twig
  5. C#
  6. Go
  7. Rust

And anything else forgetting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for design Design work is requested for dev
Projects
Status: Review 🔍
Development

Successfully merging a pull request may close this issue.

4 participants