Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] <rh-footer> doesn't gracefully degrade #2058

Open
markcaron opened this issue Nov 20, 2024 · 2 comments · May be fixed by #2067
Open

[bug] <rh-footer> doesn't gracefully degrade #2058

markcaron opened this issue Nov 20, 2024 · 2 comments · May be fixed by #2067
Assignees
Labels
bug Something isn't working

Comments

@markcaron
Copy link
Collaborator

Describe the bug

There are some -lightdom.css styles that hide content when the element is not defined. This creates a broken experience when JS doesn't load.

IMO, the Footer is an important piece of navigation and access to information. Therefore, the content within the light DOM should be styled in a progressively enhanced way—like a stacked list of links at the minimum.

Maybe there's a technical challenge I'm missing?

Screenshots

image image

Steps to reproduce

  1. Go to redhat.com or rh-footer demo
  2. Disabled JS
  3. Refresh and see broken footer (hidden links and content)

Expected behaviour

Content/links aren't hidden.

Element HTML

No response

Operating System (OS)

iOS

Browser

Chrome

Additional browser or assistive technology info

No response

@markcaron markcaron added the bug Something isn't working label Nov 20, 2024
@bennypowers
Copy link
Member

maybe we can use a css animation to reveal that content after X seconds so long as the js didn't load, but when js comes online, apply some css or a class which immediately reveals the content. WDYT?

@bennypowers bennypowers self-assigned this Nov 21, 2024
@bennypowers bennypowers linked a pull request Nov 26, 2024 that will close this issue
@markcaron
Copy link
Collaborator Author

@bennypowers we could do the CSS animation to limit CLS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants