Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add theme switcher #1824

Open
coreyvickery opened this issue Sep 4, 2024 · 7 comments
Open

[docs] Add theme switcher #1824

coreyvickery opened this issue Sep 4, 2024 · 7 comments
Assignees
@bennypowers @markcaron @coreyvickery @marionnegp
Labels
docs Improvements or additions to documentation feature New feature or request needs discovery Needs discovery needs discussion This issue needs further discussion
Milestone
2025/Q1 — Cubone ...

Comments

@coreyvickery
Copy link
Collaborator

Description

Add theme switcher to ux dot.

Links

No response

Screenshots

No response

Additional context

No response
@coreyvickery coreyvickery added docs Improvements or additions to documentation feature New feature or request needs discovery Needs discovery needs discussion This issue needs further discussion labels Sep 4, 2024
@bennypowers
Copy link
Member

Following on from private discussions around #1792

@marionnegp
Copy link
Collaborator

Some options for placement:

  • In the top nav with the logo: A con of this placement is that it doesn't resize as well down to mobile.
  • In the side nav: Could possibly position it above the "Home" nav item, like what docs.redhat.com does.

@bennypowers
Copy link
Member

We can move it around if we want. Masthead for desktop, sidebar header or footer for mobile

@coreyvickery
Copy link
Collaborator Author

@bennypowers @marionnegp Explored some ideas, icons are not from the Brand team yet.

Figma

@bennypowers
Copy link
Member

We already have a sun icon:
rhds sun icon

Here's an open issue for a moon icon:

RedHat-UX/red-hat-icons#13

@markcaron
Copy link
Collaborator

@bennypowers @coreyvickery waiting on Brand approval of new moon and system theme icons after I make a small visual tweak to the relative sizes between the sun and moon (see below).

Image

@markcaron markcaron self-assigned this Jan 9, 2025
@markcaron
Copy link
Collaborator

Related #2054

@coreyvickery coreyvickery moved this from Backlog to In Progress 🟢 in Red Hat Design System Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bennypowers bennypowers

@markcaron markcaron

@coreyvickery coreyvickery

@marionnegp marionnegp

Labels
docs Improvements or additions to documentation feature New feature or request needs discovery Needs discovery needs discussion This issue needs further discussion
Projects
Red Hat Design System
Status: In Progress 🟢
Milestone
2025/Q1 — Cubone release
Development

No branches or pull requests
4 participants
@bennypowers @markcaron @coreyvickery @marionnegp