Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] <rh-dialog> dark theme #1300

Open
marionnegp opened this issue Oct 24, 2023 · 1 comment · May be fixed by #2078
Open

[feat] <rh-dialog> dark theme #1300

marionnegp opened this issue Oct 24, 2023 · 1 comment · May be fixed by #2078
Labels
feature New feature or request for design Design work is requested good 1st issue Good first issue red hack day Good issue for Red Hack Day
Milestone
2025/Q1 — Cubone ...

Comments

@marionnegp
Copy link
Collaborator

Description

<rh-dialog> needs a dark theme version.

Suggested solution

Use dark theme surface, text, and icon colors.

Example API

No response

Additional context

No response
@marionnegp marionnegp added feature New feature or request for design Design work is requested labels Oct 24, 2023
@bennypowers bennypowers changed the title [feat] <rh-dialog> dark theme [feat] <rh-dialog> dark theme Oct 31, 2023
@marionnegp marionnegp removed this from the 2023/Q4 — Caterpie release milestone Dec 5, 2023
@markcaron markcaron added good 1st issue Good first issue red hack day Good issue for Red Hack Day labels Jun 12, 2024
@coreyvickery
Copy link
Collaborator

@marionnegp Whipped up something quick. Thoughts?

@hellogreg hellogreg linked a pull request Dec 12, 2024 that will close this issue
feat(dialog): use native HTML dialog element #2078
Open
4 tasks
@markcaron markcaron moved this from Backlog to In Progress 🟢 in Red Hat Design System Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request for design Design work is requested good 1st issue Good first issue red hack day Good issue for Red Hack Day
Projects
Red Hat Design System
Status: In Progress 🟢
Milestone
2025/Q1 — Cubone release
Development

Successfully merging a pull request may close this issue.

feat(dialog): use native HTML dialog element RedHat-UX/red-hat-design-system
4 participants
@bennypowers @markcaron @coreyvickery @marionnegp