New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues on Foundations | Personality #72

Open

1 of 2 tasks

zeroedin opened this issue Jul 17, 2023 · 1 comment

Labels

bug

Milestone

Production Launch

Collaborator

zeroedin commented Jul 17, 2023 •

edited

Loading

Couple issues I noticed on the personality page:

Fixed in Fix cta links #75 ~~CTA looks like the HTML has some errors tag closed before contents of the slotted <a>~~
When two rhb-grid are used in the tab panel looks like they might need a sibling selector to add margin between them:

rhb-grid + rhb-grid {
  margin-block-start: var(--rh-space-2xl, 32px);
}

Need to evaluate the rest of the site looking for the same pattern and see if that is what we need to do here, or a more custom rule.

The text was updated successfully, but these errors were encountered:

zeroedin added the bug label

zeroedin added this to the Production Launch milestone

Contributor

amandapearlswig commented Jul 17, 2023

CTA has been fixed, will look into adding the rbh-grid spacing suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment