Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add descriptions and meta data #71

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add descriptions and meta data #71

wants to merge 3 commits into from

Conversation

zeroedin
Copy link
Collaborator

@zeroedin zeroedin commented Jul 17, 2023 •
edited
Loading

What I did

  • Add descriptions to frontmatter yml of each page
  • Improve description and social meta tags in base layout
  • Add faviocon

Closes #60

Todo

Pages missing descriptions:

  • Foundations | Naming and trademarks
  • Design Language | Standard Icons
  • Design Language | Technology Icons
  • Design Language | UI Icons
  • Handbooks | Partner handbook
  • Handbooks | Product branding
  • Handbooks | Red Hat Marketplace
  • Logos | Digital Badges
  • Templates and Resources | Applications (Additional Resources) - needs revised

Testing instructions

View Deploy preview

Review notes:

Inspect or view source of each page to ensure correct title and description output.

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c6393b3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jul 17, 2023 •
edited
Loading

✅ Deploy Preview for prismatic-souffle-43beb6 ready!

Name Link
🔨 Latest commit c6393b3
🔍 Latest deploy log https://app.netlify.com/sites/prismatic-souffle-43beb6/deploys/64b58294ce4d1e00084d3c3a
😎 Deploy Preview https://deploy-preview-71--prismatic-souffle-43beb6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zeroedin zeroedin self-assigned this Jul 17, 2023
@zeroedin zeroedin added the feature New feature or request label Jul 17, 2023
@zeroedin zeroedin added this to the Production Launch milestone Jul 17, 2023
@zeroedin zeroedin requested a review from amandapearlswig July 17, 2023 18:04
@zeroedin zeroedin marked this pull request as ready for review July 17, 2023 18:04
@zeroedin
Copy link
Collaborator Author

@amandapearlswig do you mind filling in where we are missing descriptions from the Todo list in the PR description? If you have any questions let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amandapearlswig amandapearlswig Awaiting requested review from amandapearlswig

At least 1 approving review is required to merge this pull request.

Assignees

@zeroedin zeroedin

Labels
feature New feature or request
Projects
None yet
Milestone
Production Launch
Development

Successfully merging this pull request may close these issues.

Title and meta data per page
1 participant
@zeroedin