Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(card): add flex variant which pins the CTA to the bottom #17

Closed
wants to merge 2 commits into from
Closed

fix(card): add flex variant which pins the CTA to the bottom #17

wants to merge 2 commits into from

Conversation

zeroedin
Copy link
Collaborator

@zeroedin zeroedin commented May 4, 2023 •
edited
Loading

What I did

  1. Added a flex variant styles to rhb-card.webc component

Closes #13

Testing instructions

  1. View deploy preview typography page and see the card content for "functional type and expressive type"

@changeset-bot
Copy link

changeset-bot bot commented May 4, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c22061f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@zeroedin zeroedin self-assigned this May 4, 2023
@zeroedin zeroedin added the feature New feature or request label May 4, 2023
@netlify
Copy link

netlify bot commented May 4, 2023 •
edited
Loading

✅ Deploy Preview for prismatic-souffle-43beb6 ready!

Name Link
🔨 Latest commit c22061f
🔍 Latest deploy log https://app.netlify.com/sites/prismatic-souffle-43beb6/deploys/64666a36a02bcf0008cf5ed6
😎 Deploy Preview https://deploy-preview-17--prismatic-souffle-43beb6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@zeroedin
Copy link
Collaborator Author

zeroedin commented May 4, 2023

After further discussion via chat we decided this may not be the fix that was intended. We are going to leave this PR open for a bit and look at other scenarios to try and isolate what the initial issue / expectation was/is.

@zeroedin
Copy link
Collaborator Author

zeroedin commented Jul 17, 2023 •
edited
Loading

Closing this PR. More variations through use of rh-card will be available via patterns. See #70

@zeroedin zeroedin closed this Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zeroedin zeroedin

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rhb-card equal height
1 participant
@zeroedin