Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some merge review utilities #15

Open
alxbrg opened this issue Apr 20, 2018 · 1 comment
Open

Add some merge review utilities #15

alxbrg opened this issue Apr 20, 2018 · 1 comment
Labels
enhancement New feature or request feature request Request of a non existing feature pull request ready Someone has made a pull request for it already

Comments

@alxbrg
Copy link

alxbrg commented Apr 20, 2018

Maybe a tad out of scope at the moment, but it would be nice to have some small utils to actually review merge requests.

For example, one thing that I usually do when reviewing is git reset HEAD^ or using the commit hash of the first commit in the MR when there are several commits (and I have to do a git log and it's sometimes annoying). That way I can see all the changes inline in my IDE for instance, which is better IMO than looking at diffs and truncated files on Gitlab.

Something to think about. The other enhancements proposed until now should have priority I think.
@RamonGebben RamonGebben added enhancement New feature or request feature request Request of a non existing feature labels Apr 20, 2018
RamonGebben added a commit that referenced this issue Apr 20, 2018
@RamonGebben
#15: Added review command
1563df5
@RamonGebben RamonGebben mentioned this issue Apr 20, 2018
Open
2 tasks
RamonGebben added a commit that referenced this issue Apr 23, 2018
@RamonGebben
#15: Using short SHA's and showing commit messages
efc60ef
@RamonGebben
Copy link
Owner

@alxbrg Could you test #15 and tell me if I can close this issue after merging that?

@jlengrand jlengrand added the pull request ready Someone has made a pull request for it already label Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature request Request of a non existing feature pull request ready Someone has made a pull request for it already
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jlengrand @RamonGebben @alxbrg