Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] V2: Important types like SVGAttributes are not exported #7212

Open
fabian-hiller opened this issue Dec 30, 2024 · 5 comments
Open

[🐞] V2: Important types like SVGAttributes are not exported #7212

fabian-hiller opened this issue Dec 30, 2024 · 5 comments
Assignees
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working

Comments

@fabian-hiller
Copy link
Contributor

Which component is affected?

Qwik Runtime

Describe the bug

In some components like this one I need to access the generated JSX types but they are not exported in the build of Qwik core in dist/core-internal.d.ts.

Reproduction

https://stackblitz.com/edit/github-o2f6fj9n?file=src%2Fcomponents%2FCheckIcon.tsx

Steps to reproduce

No response

System Info

-

Additional Information

No response

@fabian-hiller fabian-hiller added STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working labels Dec 30, 2024
@JerryWu1234
Copy link
Contributor

What expectation do you want ?

@fabian-hiller
Copy link
Contributor Author

I expect to be able to import Qwik's JSX TS types somehow. Otherwise, I am forced to manually copy them into my project.

@wmertens
Copy link
Member

@fabian-hiller care to make a PR? It's just a few lines and running API.update

@JerryWu1234
Copy link
Contributor

JerryWu1234 commented Jan 1, 2025

@fabian-hiller care to make a PR? It's just a few lines and running API.update

I could do it if @fabian-hiller isn't available

@JerryWu1234 JerryWu1234 self-assigned this Jan 2, 2025
@JerryWu1234 JerryWu1234 moved this from Backlog to In progress in Qwik Development Jan 2, 2025
@Varixo
Copy link
Member

Varixo commented Jan 2, 2025

the PropsOf<'svg'> isn't the same?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
STATUS-1: needs triage New issue which needs to be triaged TYPE: bug Something isn't working
Projects
Status: In progress
Development

No branches or pull requests

4 participants