Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up versioning shenanigans involving LoaderVersion and QuiltMappingsVersion #14

Open
EnnuiL opened this issue Jun 17, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@EnnuiL
Copy link

EnnuiL commented Jun 17, 2023

The separator and build fields were big mistakes and they should be rectified;
Quilt Loader never really fit into that paradigm due to it following SemVer and instead, these two fields should be replaced with a stable field akin to what GameVersion has, with SemVer being used to detect non-stable releases;
Now as for Quilt Mappings, separator should still be removed, but extra care should be taken for replacing the build field, especially since the Quilt Mappings versioning scheme is weird and with QM v2 in the plans, it's likely it can end changing to something unrecognizable
Finally, I believe we can drop the hashed field for QuiltMappingsVersionV4, we can add it back later if it ends being necessary (example: Tiny v3 happens and a JSON object would be needed), at least if it can be added back later

@ix0rai ix0rai added the enhancement New feature or request label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants