-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache #49
Comments
@RichardLindhout I have thought about that! 😁 But that would require some harder thinking. |
But expect it in |
I noticed the slow build times on https://github.com/nikolaxhristov/astro.build.compress.critters, as well and also some errors ough |
@NikolaRHristov does this work now, would be really cool! |
Hey @RichardLindhout, still not I'm afraid 😅 That's why |
I have some time over the weekend so I'll give it a crack. |
Wow that would be so great!! |
Hey @NikolaRHristov Thanks again for opening that PR against FusionAuth! I know you are trying to pull back from this project, but did you have thoughts on how this would work? I might hack on this and make a PR if you haven't gotten very far. |
Yeah, no problem! I've been thinking about using the internal sequenceDiagram
participant User
participant AstroCompress
participant Cache
participant FilesPipe
participant Git
User->>AstroCompress: Input Files
loop Check Cache
AstroCompress->>Cache: Check if cached
Cache-->>AstroCompress: Cache status
end
alt Cache Found
AstroCompress->>Cache: Retrieve from Cache
Cache-->>AstroCompress: Cached Files
else Cache Not Found
AstroCompress->>FilesPipe: Process Files
FilesPipe-->>AstroCompress: Processed Files
AstroCompress->>Cache: Store in Cache
Cache-->>AstroCompress: Cache Stored
AstroCompress->>Git: Commit Processed Files
Git-->>AstroCompress: Commit ID
end
Git->>User: Commit ID
alt Processed Files Changed
AstroCompress->>Cache: Replace Cached Files
Cache-->>AstroCompress: Replacement Done
end
AstroCompress->>User: Output Files
That way you can stage that folder in |
This would ideally be implemented in |
This is very well still in its ideation stage and PRs are welcome. |
Thank you, I love your package. |
🙏🏻 Yeah, same, this is a hard feature. |
It would be nice if there would a cache folder where the already compressed images are in so they won't need a new compression. It takes long to do the images on my website currently so deployment is slower.
The text was updated successfully, but these errors were encountered: