New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Broken `Edit on GitHub` link 🐛 #15

Open

jbampton opened this issue Jun 8, 2021 · 6 comments

Labels

bug good first issue hacktoberfest help wanted

Member

jbampton commented Jun 8, 2021

https://docs.onelang.org/#/en/trying-out-the-language

jbampton added the bug label

jbampton changed the title ~~Broken Edit on GitHub link~~ 🐛 Broken Edit on GitHub link 🐛

Member

BaseMax commented Jun 10, 2021

Click on the link works correctly.

But Right click and press "open in a new tab" wont works.

Member

BaseMax commented Jun 10, 2021

The edit href link created at runtime when clicked at onClick event so default value of link in HTML is not correct!

Monicahinga commented Sep 2, 2021

The link is working.

Member Author

jbampton commented Sep 2, 2021

Seems to be working now !! Thank you

jbampton closed this as completed

Monicahinga commented Sep 2, 2021 via email

Welcome John. Much appreciated !!

On Thu, Sep 2, 2021 at 3:24 AM John Bampton ***@***.***> wrote: Seems to be working now !! Thank you — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AVLMCUT35P3RVA6EONZIGCDT75GETANCNFSM46KQENGQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

jbampton reopened this

Member Author

jbampton commented Sep 3, 2021

"But Right click and press "open in a new tab" wont works" as @BaseMax says

jbampton added help wanted good first issue labels

jbampton added the hacktoberfest label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment