Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HSTS current state is not detected properly #118

Open
matt-richardson opened this issue Feb 20, 2018 · 0 comments
Open

HSTS current state is not detected properly #118

matt-richardson opened this issue Feb 20, 2018 · 0 comments

Comments

@matt-richardson
Copy link
Contributor

When enabling HSTS on a server that is already configured with the requested settings:

    cOctopusServer "Configure Octopus Server" {
      Ensure                           = "Present"
...
      HSTSEnabled                      = $true
      HSTSMaxAge                       = 31536000
...
    }

image

The output shows:

(FOUND MISMATCH) Configuration parameter  'HSTSMaxAge' with value 'False' mismatched the specified value '31536000'
(FOUND MISMATCH) Configuration parameter  'HSTSEnabled' with value 'False' mismatched the specified value 'True'

The show-configuration outputs:

<set key="Octopus.WebPortal.HttpStrictTransportSecurityEnabled">True</set> 
<set key="Octopus.WebPortal.HttpStrictTransportSecurityMaxAge">31536000</set> 

it appears the code is checking the wrong parameters, and also doing a [System.Convert]::ToBoolean(...) on the max age.

@matt-richardson matt-richardson self-assigned this Feb 20, 2018
@matt-richardson matt-richardson removed their assignment Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant