Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty Installation Guide #411

Open
lstoex opened this issue Oct 14, 2024 · 0 comments
Open

Faulty Installation Guide #411

lstoex opened this issue Oct 14, 2024 · 0 comments
Assignees

Comments

@lstoex
Copy link

lstoex commented Oct 14, 2024

  1. cuRobo installation mode python, isaac sim
  2. python version: 3.10
  3. Isaac Sim version (if using): 4.0.0

Issue Details

While installing cuRobo + IsaacSim + NVBlox natively, I noticed a couple of bugs/typos in the installation guide.

In the following, I refer to the instructions below Installing nvblox for PRECXX11_ABI and Isaac Sim

cd ${PKGS_PATH} &&  git clone https://github.com/valtsblukis/nvblox.git && cd ${PKGS_PATH}/nvblox/nvblox mkdir build && cd build && \
cmake ..  -DBUILD_REDISTRIBUTABLE=ON \
-DCMAKE_CXX_FLAGS=-D_GLIBCXX_USE_CXX11_ABI=0  -DPRE_CXX11_ABI_LINKABLE=ON \
-DSQLITE3_BASE_PATH="${PKGS_PATH}/sqlite/install/" -DGLOG_BASE_PATH="${PKGS_PATH}/glog/install/" \
-DGFLAGS_BASE_PATH="${PKGS_PATH}/gflags/install/" -DCMAKE_CUDA_FLAGS=-D_GLIBCXX_USE_CXX11_ABI=0 && \
make -j32 && \
sudo make install

In the first line, there is a missing && between cd ${PKGS_PATH}/nvblox/nvblox and mkdir build.

But what's more severe:

cd ${PKGS_PATH} &&  git clone https://github.com/NVlabs/nvblox_torch.git && cd nvblox_torch
sh install.sh $(python -c 'import torch.utils; print(torch.utils.cmake_prefix_path)')
python -m pip install -e .

is not going to work because CMake will have no way to find the installation of Glog we did in a previous step.
Analogously to the commands seen above, I fixed this by passing -DGLOG_BASE_PATH="${PKGS_PATH}/glog/install" within install.shand modifiedsrc/nvblox_torch/cpp/CMakeLists.txt` to include

set(GLOG_LIBRARIES "${GLOG_BASE_PATH}/lib/libglog.a")
set(GLOG_INCLUDE_DIRS "${GLOG_BASE_PATH}/include")

Also make sure that target_link_librariescorrectly uses this variable afterwards by writing it uppercase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants