-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix perplexity logging #622
Open
sichu2023
wants to merge
7
commits into
main
Choose a base branch
from
sichu/torchmetric-ppl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichu2023
requested review from
farhadrgh,
dorotat-nv,
jstjohn,
malcolmgreaves,
pstjohn,
skothenhill-nv and
trvachov
as code owners
January 17, 2025 21:34
sichu2023
force-pushed
the
sichu/torchmetric-ppl
branch
2 times, most recently
from
January 17, 2025 23:02
8f13212
to
6800366
Compare
sichu2023
requested review from
nvdreidenbach,
DejunL and
guoqing-zhou
as code owners
January 17, 2025 23:02
sichu2023
force-pushed
the
sichu/torchmetric-ppl
branch
from
January 17, 2025 23:03
6800366
to
aad63ec
Compare
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 86.62% 86.57% -0.05%
==========================================
Files 116 116
Lines 6961 6929 -32
==========================================
- Hits 6030 5999 -31
+ Misses 931 930 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: sichu <[email protected]>
Signed-off-by: sichu <[email protected]>
Signed-off-by: sichu <[email protected]>
Signed-off-by: sichu <[email protected]>
sichu2023
force-pushed
the
sichu/torchmetric-ppl
branch
from
January 18, 2025 03:14
ea78996
to
0bd0330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace callback method in logging perplexity with torchmetrics.
Loss curve is shifted by a constant when TP=2 but gradient is not affected and the perplexity value match with the loss curve without TP. This is a previously unidentified problem and will be resolved by another PR.