add generic torchmetric ppl logging on esm2 #557
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sichu2023
force-pushed
the
sichu/torchmetrics-ppl-logging-generic
branch
from
c70af90 to
41fa775
Compare
…n_value_without_parallelism
This reverts commit a698ad4.
sichu2023
force-pushed
the
sichu/torchmetrics-ppl-logging-generic
branch
from
41fa775 to
952b47b
Compare
sichu2023
force-pushed
the
sichu/torchmetrics-ppl-logging-generic
branch
from
070d57e to
4a3ff2c
Compare
|
Moved to #622 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Logging perplexity through
torchmetric.text.PerplexityDetails
Pipeline parallel last stage is handled in
training_stepandvalidation_step. Generic torchmetric seems to handle tensor parallelism without any noticeable difference, where the logits are already provided intraining/validation_stepand no backward pass is needed.However, valid_ppl does not seem to work properly.
Usage