Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version being saved as 0.0.0 #365

Open
scarlehoff opened this issue Apr 30, 2024 · 3 comments
Open

Version being saved as 0.0.0 #365

scarlehoff opened this issue Apr 30, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@scarlehoff
Copy link
Member

scarlehoff commented Apr 30, 2024

Not sure whether this is a bug or a feature request tbh, but I was expecting to get 0.14.2-some-git-hash instead of 0.0.0.

If it is a bug, I can modify a bit the pyproject.toml to get the hash.
If it is a feature request, is it fine if I modify the pyproject.toml to get the hash as well?

@scarlehoff scarlehoff added the bug Something isn't working label Apr 30, 2024
@felixhekhorn
Copy link
Contributor

How did you install? I think poetry-dynamic-versioning only creates the version string upon deployment, so most likely you installed locally and so it points to 0.0.0 - if you install from pip this would not happen I think ... I'm not sure there is another easy way in poetry to get what you want ...

@scarlehoff
Copy link
Member Author

Locally.

Yes, you can get it also when installing locally (we do so in nnpdf... https://github.com/NNPDF/nnpdf/blob/bd41add4fd0246ec4be4a9223e190c5fee44fc8d/pyproject.toml#L3
to first approximation just changing the build backend might work, but I'll need to test)

@alecandido
Copy link
Member

It's just a new feature of poetry-dynamic-versioning. nnpdf just got Poetry much after eko.

If you wish, feel free to update it directly in master.

@felixhekhorn felixhekhorn mentioned this issue May 20, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants