Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistently adopt EvolutionPoint #265

Open
2 tasks
alecandido opened this issue May 12, 2023 · 2 comments
Open
2 tasks

Consistently adopt EvolutionPoint #265

alecandido opened this issue May 12, 2023 · 2 comments
Labels
refactor Refactor code

Comments

@alecandido
Copy link
Member

Even after #242, there are still places in which we could make use of an EvolutionPoint (i.e. it would be the conceptually correct object), but we keep passing just a scale, and optionally a number of flavors (optionally both because it may default to None, but even because we may not allow for it at all).

E.g.

eko/src/eko/couplings.py

Lines 712 to 716 in 431a055

def a(
self,
scale_to,
nf_to=None,
):

where clearly (scale_to, nf_to) = target: EvolutionPoint.

This propagates down to the Atlas, that sometimes has to deal with an unspecified number of flavors, and it is the reason for the Atlas.normalize() function.

self.origin = self.normalize(origin)

mu2f, nff = self.normalize(target)

  • use EvolutionPoints consistently
    • especially in eko.couplings and eko.msbar_masses
  • drop Atlas.normalize()
@alecandido alecandido added the refactor Refactor code label May 12, 2023
@felixhekhorn
Copy link
Contributor

This is related to #248

@alecandido
Copy link
Member Author

This is related to #248

Almost: that's another instance, but a special one, because it is part of our minimal public API.

Actually, here I'd like to address everything but that one in particular :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor code
Projects
None yet
Development

No branches or pull requests

2 participants