Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the selected language to i18n.locale so the app language changes. #343

Closed
wants to merge 1 commit into from
Closed

Set the selected language to i18n.locale so the app language changes. #343

wants to merge 1 commit into from

Conversation

hb2708
Copy link
Contributor

@hb2708 hb2708 commented Oct 30, 2021 •
edited
Loading

✅ I have read the contributing file

Summary

This PR Fixes #249
By Enabling app to show string based on user-selected language

Changelog

Add call to set i18n.locale when user change language from language screen

Demo

RPReplay_Final1635614236

@hb2708 hb2708 mentioned this pull request Oct 30, 2021
Open
1 task
@hb2708
Copy link
Contributor Author

hb2708 commented Oct 30, 2021

it's not very smooth mainly the add Emission -> Main category list does not show localized text.

@hb2708 hb2708 marked this pull request as ready for review October 30, 2021 17:19
PierreBresson
PierreBresson requested changes Oct 31, 2021
View reviewed changes
Copy link
Member

@PierreBresson PierreBresson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, it doesn’t work (cf bottom tap bar)

@hb2708
Copy link
Contributor Author

hb2708 commented Nov 1, 2021

Yes agreed will need to find better way to let app reflect the language as perfectly as possible

@PierreBresson
Copy link
Member

Closing for inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreBresson PierreBresson PierreBresson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing language when app is mounted 🌐
2 participants
@hb2708 @PierreBresson