-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling of notes #8
Comments
@andreyzhd regarding the first item, note the trial selection by tags is done by the following line: gaitutils/gaitutils/sessionutils.py Line 237 in f19622d
Meaning, for the trial to be included, it's enough for the tag (e.g. E1) to show up anywhere in any of the relevant Eclipse fields. Thus, 'E1, running' should already go into the web report. Regarding showing the comment, I recall the web report by default shows only the tag (at least in plot legends). This is to save space, since the legends easily become overlong. However this is configurable in gaitutils/gaitutils/data/default.cfg Line 440 in 3f2be60
Try e.g. legend_type='full' and see what happens. This option is passed on to the Plotly/matplotlib plotters, so you can investigate that part of the code for more details.For the second item, see gaitutils/gaitutils/report/web.py Line 214 in 3f2be60
Thus, a hardcoded rule is that the report will only collect one trial for each 'video tag' that has been configured. Thus, using the video tag 'toe standing' will only collect one toe standing trial. For a fix, it might be enough to define two video tags: 'toe standing' and 'toe standing continued'. Alternatively, you might just remove the check referenced above, so it collects multiple video trials for any given video tag. (This might have side effects, but right now I cannot think of any). |
For multiple video tags, probably the only thing that may need rethinking is the video selector box in the web report. Right now the logic is simple, because you will have precisely one entry for each video tag in the selector box, and one corresponding trial. |
Add session-level notes to the web and pdf reports
Change trial level notes:
E1, running
andE1 running
should be treated asE1
for the purpose of inclusion into web or pdf report.running
is a comment here and should be displayed somewhere in the web/pdf report.toe standing
andtoe standing continued
, both should be included into the web report. This should work, at least, for thetoe standing
andunipedal ...
trials (Can this be easily extended to all trials?).The text was updated successfully, but these errors were encountered: