Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of notes #8

Open
andreyzhd opened this issue Nov 28, 2022 · 2 comments
Open

Improve handling of notes #8

andreyzhd opened this issue Nov 28, 2022 · 2 comments

Comments

@andreyzhd
Copy link
Collaborator

Add session-level notes to the web and pdf reports
Change trial level notes:

  • E1, running and E1 running should be treated as E1 for the purpose of inclusion into web or pdf report. running is a comment here and should be displayed somewhere in the web/pdf report.
  • If there are trials toe standing and toe standing continued, both should be included into the web report. This should work, at least, for the toe standing and unipedal ... trials (Can this be easily extended to all trials?).
@jjnurminen
Copy link
Collaborator

jjnurminen commented Nov 28, 2022

@andreyzhd regarding the first item, note the trial selection by tags is done by the following line:

if any(pattern.upper() in eclval for eclval in eclvals):

Meaning, for the trial to be included, it's enough for the tag (e.g. E1) to show up anywhere in any of the relevant Eclipse fields. Thus, 'E1, running' should already go into the web report. Regarding showing the comment, I recall the web report by default shows only the tag (at least in plot legends). This is to save space, since the legends easily become overlong. However this is configurable in
legend_type = 'tag_with_cycle'

Try e.g. legend_type='full' and see what happens. This option is passed on to the Plotly/matplotlib plotters, so you can investigate that part of the code for more details.
For the second item, see
if len(dyn_vids) > 1:

Thus, a hardcoded rule is that the report will only collect one trial for each 'video tag' that has been configured. Thus, using the video tag 'toe standing' will only collect one toe standing trial. For a fix, it might be enough to define two video tags: 'toe standing' and 'toe standing continued'. Alternatively, you might just remove the check referenced above, so it collects multiple video trials for any given video tag. (This might have side effects, but right now I cannot think of any).

@jjnurminen
Copy link
Collaborator

For multiple video tags, probably the only thing that may need rethinking is the video selector box in the web report. Right now the logic is simple, because you will have precisely one entry for each video tag in the selector box, and one corresponding trial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants