Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite commands in OOP style 😎 #23

Open
SageStarCodes opened this issue May 15, 2018 · 0 comments
Open

Rewrite commands in OOP style 😎 #23

SageStarCodes opened this issue May 15, 2018 · 0 comments
Assignees
@SageStarCodes
Labels
dev This issue is related to the dev branch rewrite A rewrite is needed for the issue to be fixed TypeScript Issue is about the TypeScript rewrite
Milestone
1.1.0

Comments

@SageStarCodes
Copy link
Contributor

Commands are currently using module.exports and exporting objects, this is not they way it should be done in TypeScript and they should be rewritten using classes.
@SageStarCodes SageStarCodes added the dev This issue is related to the dev branch label May 15, 2018
@SageStarCodes SageStarCodes added this to the 1.1.0 milestone May 15, 2018
@SageStarCodes SageStarCodes self-assigned this May 15, 2018
@SageStarCodes SageStarCodes added TypeScript Issue is about the TypeScript rewrite rewrite A rewrite is needed for the issue to be fixed labels May 15, 2018
SageStarCodes added a commit that referenced this issue May 15, 2018
@SageStarCodes
Complete the rewrite to TypeScript
5e0ea47 
closes #20, closes #23

😎
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SageStarCodes SageStarCodes

Labels
dev This issue is related to the dev branch rewrite A rewrite is needed for the issue to be fixed TypeScript Issue is about the TypeScript rewrite
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
1 participant
@SageStarCodes