Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reading JSON text from file is very slow #30

Closed
MrWoafer opened this issue Nov 8, 2024 · 2 comments
Closed

Reading JSON text from file is very slow #30

MrWoafer opened this issue Nov 8, 2024 · 2 comments
Labels
performance A performance issue

Comments

@MrWoafer
Copy link
Owner

MrWoafer commented Nov 8, 2024

No description provided.

@MrWoafer MrWoafer converted this from a draft issue Nov 8, 2024
@MrWoafer
Copy link
Owner Author

MrWoafer commented Nov 9, 2024

Cause is that System.IO.File.ReadAllText() is very slow for large files. I will fix this by using a StreamReader instead.

@MrWoafer MrWoafer added the performance A performance issue label Nov 9, 2024
@MrWoafer
Copy link
Owner Author

It is only slow for large files. I will soon make .pac files use byte serialisation instead of JSON so this will no longer be an issue.

@MrWoafer MrWoafer closed this as not planned Won't fix, can't repro, duplicate, stale Nov 10, 2024
@MrWoafer MrWoafer linked a pull request Nov 16, 2024 that will close this issue
Clean up util functions #40
Open
@MrWoafer MrWoafer removed a link to a pull request Nov 16, 2024
Clean up util functions #40
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance A performance issue
Projects
Pixel Art Creator 2.0 - Bug Tracker
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrWoafer