Skip to content
This repository has been archived by the owner on May 25, 2020. It is now read-only.

Improve maintainability score to A #195

Open
grgur opened this issue Sep 4, 2018 · 4 comments
Open

Improve maintainability score to A #195

grgur opened this issue Sep 4, 2018 · 4 comments

Comments

@grgur
Copy link
Member

grgur commented Sep 4, 2018

Current maintainability score is B. Code climate shows how to improve that score here: https://codeclimate.com/github/ModusCreateOrg/budgeting

Let's get that A!

@nelsonomuto
Copy link
Contributor

one of the things required is a codeclimate config to ignore the flow-typed directory

@nelsonomuto
Copy link
Contributor

that reduces the number of files being analyzed from over 240 to 177.

then there are a few invalid "duplication" issues being raised, those need to be marked invalid; mostly with regards to the unit tests.

after this it reduces the amount of issues drastically

screen shot 2018-09-22 at 4 48 06 pm

@nelsonomuto
Copy link
Contributor

@grgur
I don't have access to the Code Climate as a member so I can't mark anything as "invalid" but here is a link to my code climate report https://codeclimate.com/github/nelsonomuto/budgeting

Here's a PR to add the .codeclimate.yml config to exclude the flow-typed directory: #201

@grgur
Copy link
Member Author

grgur commented Sep 24, 2018

@nelsonomuto thank you so much for contributing! This gets us a lot closer to the target https://codeclimate.com/github/ModusCreateOrg/budgeting

I believe the other improvements fall into the fun re-org category :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants