Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/658-remove-cross-fetch-from-server #661

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix/658-remove-cross-fetch-from-server #661

wants to merge 2 commits into from

Conversation

MasterKale
Copy link
Owner

@MasterKale MasterKale commented Dec 16, 2024 •
edited
Loading

This PR removes the cross-fetch dependency from @simplewebauthn/server as it's no longer needed thanks to the project targeting Node 20+.

I'm keeping the fetch() helper around to make it easier to mock responses during testing.

Fixes #658.

@MasterKale MasterKale marked this pull request as ready for review December 16, 2024 15:07
@MasterKale MasterKale added this to the v13.0.1 milestone Dec 16, 2024
@MasterKale MasterKale added the package:server @simplewebauthn/server label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package:server @simplewebauthn/server
Projects
None yet
Milestone
v13.0.1
Development

Successfully merging this pull request may close these issues.

Remove cross-fetch as a server package dependency
1 participant
@MasterKale