-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather Module not loading since MM update #3574
Comments
I'm getting the same with OpenWeatherMap:
and
Doesn't seem right to switch providers to fix this. |
@JHenzi can you post the module info for weather from config.js xxx out your apikey |
They switched the default API version to 3.0, don't know why I doens't work anymore. But when you add |
The addition of
|
Closed the Issue as fixed with adding the apiVersion: „2.5“ |
This isn't fixed! API Version 2.5 is deprecated. It was supposed to be retired in June of 2024. This needs a real fix, everyone has to migrate to version 3.0. Your default weather service is going to stop working and does NOT work without a code change already. |
@JHenzi we changed because of their notice. 3.0 is the only official api |
ReOpened due to request for an update to api 3.0 |
Nothing needs to be fixed with the code. You need to get a new V3 API key at openweathermap.com |
I have an API 3.0 account and the weather is not loading. The same API is working with other modules for weather (/scottcl88/MMM-DynamicWeather) but the default weather module is not working after the update. If you setup a payment method you can limit it to 1000 per day so you never have to pay. I've had it setup for months and have yet to get a bill from them or see anything. It's just like the free account but API 3.0. |
before 2.29 (yesterday) the default weather module used 2.5 in the url |
Oh thank you, @JHenzi this was driving me crazy before I thought to look here. I have three magic mirrors running. 1000 is probably still enough, but still. I kinda think the default option for a standard model probably shouldn't be to an API service that even just MIGHT require a fee. To much danger for an unsuspecting user who just accidentally does something wrong. |
@chrismaverick we provide different providers |
@sdetweil yes, I know. But the module defaults to openweathermap, so I am presuming that's the most likely to be used by those who are least able to understand what is happening. |
we did that because it gave the best results now so long ago, and was free. still is under most circumstances |
MM doesnt start when i was adding apiVersion: "2.5" to the config.js But when i change apiVersion: "3.0" here ~/MagicMirror/modules/default/weather/providers/openweathermap.js- to "2.5" it solved the problem and weather was working again |
so you missed a comma after and maybe before 2.5 WILL end sometime. was supposed to be june don't edit our files. all config changes go in config.js |
I recieved this yesterday via email: "We would like to inform you that we started One Call 2.5 deprecation, and your access to the product will be stopped on October 14, 2024." |
thanks, i did not receive that notice |
I think i did it right. It looked like the post above. But it didnt worked. Sorry i am a beginner dont know so much about MM. I also subscribbed to API 3.0 on openweather but i dont know what to do now. I dont get any special "3.0" API. They only send me this UPDATE: Ok i think it was the comma. Will try it when i am home |
many posters don't post the 'exact' text, so you have to know. sometimes they don't post it correctly and the forum software changes the quote marks too. you need to know how to discover and fix it the 3.0 api also requires an additional config parm
|
Hello TeaMM, I just discover the OpenWeather API issue... 👎 Just a quick question: I have a Netatmo weather station, could you please make it an official data provider for the module ? I am not a developer, but if necessary, I can provide API keys to help you... And make an official request for change... It would be so "magic" 😇 |
since API 3.0 is default, weatherEndpoint should be set to "/onecall" Fixes #3574 ATTENTION: since lat / lon defaults to 0 / 0, the weather plugins works after this patch, but shows the weather from https://de.wikipedia.org/wiki/Null_Island if lat / lon is not manually set. --------- Co-authored-by: Karsten Hassel <[email protected]> Co-authored-by: Pedro Lamas <[email protected]>
Hello, Thanks for a fix in advance =) |
@AWSW-de not what we want, but what we get. OW has changed their business model and api to match . you MUST supply a credit card to get access to the new api, ( w an uncharged count so far of 1000 requests per day) and you must change the parameters to our weather module, as location and locationID no longer work. the api requires latitude and longitude now. you must also supply a new parm as they only provide one now as they told us in emails, this transition has been going on for 2 years , and they are making it final. |
Thanks. Should have read the complete post before. |
possible |
If someone comes here and is just looking for it, here is How to Update to a OpenWeatherMap 3.0 KeyYou will need a credit card to do this, but you can limit your calls to the free limit and theoretically you will never be charged.
I use two modules, and my new config looks like this [
{
module: "weather",
position: "top_left",
config: {
weatherProvider: "openweathermap",
weatherEndpoint:"/onecall",
type: "current",
lat: 40.748440,
lon: -73.985664,
apiKey: "$WEATHER_API_KEY"
}
},
{
module: "weather",
position: "top_left",
header: "Weather Forecast",
config: {
weatherProvider: "openweathermap",
weatherEndpoint:"/onecall",
type: "forecast",
lat: 40.748440,
lon: -73.985664,
apiKey: "$WEATHER_API_KEY"
}
},
] Sub out your Key and your lat/lon (these are not mine) The api key at first was getting 401 errors, but after a bit it started working, the same key I was using before. Their FAQ mentions it can take a few hours I am not worried about usage. The default If I'm wrong or missed something let me know and I can edit this. edited: the old 2.5 api returned the location name from the location/locationID parms.. the new api uses lat/lon and does NOT header: "somestring to show above the module output", // as you wish for this module AND appendLocationNameToHeader: false, in the config section |
@JHWelch works so far. But how do I get the name of the city back into the header? I now have the name of the city from the corresponding time zone or the capital, i.e. Berlin/Europe. |
@z-master42 you need to change the config set whatever you want in the module header, above the config:{ |
Damn. I must have gone through the documentary five times. Either I always missed it, or I just didn't realise the function of Thank you! |
## [2.30.0] - 2025-01-01 Thanks to: @xsorifc28, @HeikoGr, @bugsounet, @khassel, @KristjanESPERANTO, @rejas, @sdetweil. >⚠️ This release needs nodejs version `v20` or `v22 or higher`, minimum version is `v20.18.1` ### Added - [core] Add wayland and windows start options to `package.json` (#3594) - [docs] Add step for npm publishing in release process (#3595) - [core] Add GitHub workflow to run spellcheck a few days before each release (#3623) - [core] Add test flag to `index.html` to pass to module js for test mode detection (needed by #3630) - [core] Add export on animation names (#3644) - [compliments] Add support for refreshing remote compliments file, and test cases (#3630) - [linter] Re-add `eslint-plugin-import`now that it supports ESLint v9 (#3586) - [linter] Re-activate `eslint-plugin-package-json` to lint `package.json` (#3643) - [linter] Add linting for markdown files (#3646) - [linter] Add some handy ESLint rules. - [calendar] Add ability to display end date for full date events, where end is not same day (showEnd=true) (#3650) - [core] Add text to the config.js.sample file about the locale variable (#3654, #3655) - [core] Add fetch timeout for all node_helpers (thru undici, forces node 20.18.1 minimum) to help on slower systems. (#3660) (3661) ### Changed - [core] Run code style checks in workflow only once (#3648) - [core] Fix animations export #3644 only on server side (#3649) - [core] Use project URL in fallback config (#3656) - [core] Fix Access Denied crash writing js/positions.js (on synology nas) #3651. new message, MM starts, but no modules showing (#3652) - [linter] Switch to 'npx' for lint-staged in pre-commit hook (#3658) ### Removed - [tests] Remove `node-pty` and `drivelist` from rebuilded test (#3575) - [deps] Remove `@eslint/js` dependency. Already installed with `eslint` in deep (#3636) ### Updated - [repo] Reactivate `stale.yaml` as GitHub action to mark issues as stale after 60 days and close them 7 days later (if no activity) (#3577, #3580, #3581) - [core] Update electron dependency to v32 (test electron rebuild) and all other dependencies too (#3657) - [tests] All test configs have been updated to allow full external access, allowing for easier debugging (especially when running as a container) - [core] Run and test with node 23 (#3588) - [workflow] delete exception `allow-ghsas: GHSA-8hc4-vh64-cxmj` in `dep-review.yaml` (#3659) ### Fixed - [updatenotification] Fix pm2 using detection when pm2 script is inside or outside MagicMirror root folder (#3576) (#3605) (#3626) (#3628) - [core] Fix loading node_helper of modules: avoid black screen, display errors and continue loading with next module (#3578) - [weather] Change default value for weatherEndpoint of provider openweathermap to "/onecall" (#3574) - [tests] Fix electron tests with mock dates, the mock on server side was missing (#3597) - [tests] Fix testcases with hard coded Date.now (#3597) - [core] Fix missing `basePath` where `location.host` is used (#3613) - [compliments] croner library changed filenames used in latest version (#3624) - [linter] Fix ESLint ignore pattern which caused that default modules not to be linted (#3632) - [core] Fix module path in case of sub/sub folder is used and use path.resolve for resolve `moduleFolder` and `defaultModuleFolder` in app.js (#3653) - [calendar] Update to resolve issues #3098 #3144 #3351 #3422 #3443 #3467 #3537 related to timezone changes - [calendar] Fix #3267 (styles array), also fixes event with both exdate AND recurrence(and testcase) - [calendar] Fix showEndsOnlyWithDuration not working, #3598, applies ONLY to full day events - [calendar] Fix showEnd for Full Day events (#3602) - [tests] Suppress "module is not defined" in e2e tests (#3647) - [calendar] Fix #3267 (styles array, really this time!) - [core] Fix #3662 js/positions.js created incorrectly --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Michael Teeuw <[email protected]> Co-authored-by: Kristjan ESPERANTO <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Karsten Hassel <[email protected]> Co-authored-by: Ross Younger <[email protected]> Co-authored-by: Veeck <[email protected]> Co-authored-by: Bugsounet - Cédric <[email protected]> Co-authored-by: jkriegshauser <[email protected]> Co-authored-by: illimarkangur <[email protected]> Co-authored-by: vppencilsharpener <[email protected]> Co-authored-by: veeck <[email protected]> Co-authored-by: Paranoid93 <[email protected]> Co-authored-by: Brian O'Connor <[email protected]> Co-authored-by: WallysWellies <[email protected]> Co-authored-by: Jason Stieber <[email protected]> Co-authored-by: jargordon <[email protected]> Co-authored-by: Daniel <[email protected]> Co-authored-by: Ryan Williams <[email protected]> Co-authored-by: Panagiotis Skias <[email protected]> Co-authored-by: Marc Landis <[email protected]> Co-authored-by: HeikoGr <[email protected]> Co-authored-by: Pedro Lamas <[email protected]> Co-authored-by: veeck <[email protected]>
After updating from 2.28.0 to 2.30.0 my weather plugin wasn't loading correctly. The documentation for the weather plugin is not up to date because it says the default value is: apiVersion = '2.5' and weatherEndpoint = '/weather'. I saw, that the default was changed to apiVersion = 3.0 and weatherEndpoint = '/onecall' in 2.29.0. I then read the Openweathermap API information. I believe that the API version 2.5 remains, only the /onecall call has been deprecated. Or have I misunderstood something? Therefore, after the update to 2.30.0, I adjusted my config as follows and lo and behold, everything works:
|
The OpenWeatherMap must be update to version 3.0 instead of your 2.5. I subscribed to the 3.0 version today and after half an hour it worked. For an explaination how to upgrade, see the reaction of @JHWelch above. |
@princemaxwell that is not how we understood the communication from OpenWeather. they have long said they will be discontinuing their 2.5 api (over 2 years) |
@SirStepheno @sdetweil For current & forecast, the API documentation still describes 2.5, see here: It works again for me with the config I just posted. |
as I said, that is not the way we read the communications. |
OK, maybe I misunderstood it. I got my information from the current FAQ on the API and it still describes the call to 2.5 and after I adjusted it, it works for me with 2.5, let's see how long. Nevertheless, the current documentation should still be adjusted to the new default values. |
yes this issue calls for doc update, that no one worked on for this release.. we are all volunteers, anyone can contribute |
i can contribute this, but don't know what was changed else, so makes that sense? |
@princemaxwell fork the doc repo, https://github.com/MagicMirrorOrg/MagicMirror-Documentation switch to develop branch, make a new branch, update as you think, |
Hi all,
i did the MM Update few days ago (Notifikation in the bottom bar) via git pull. Until the Update everything worked fine, but since the Update was done, the Weather Module is not loading any more. All other modules are fine after the update. I dont see anything in the logs. Would be great if someone could help me figuring out whats going on.
System: Raspi Zero 2W with PoE LAN Hat
Node: v22.9.0
OS: Debian 12 Bookworm latest update/upgrade
Electron: v32.1.2
MagicMirror Version: 2.29.0
Weather Module API is OpenWeather Map
API Key is valid and checked.
Config-Part of Weather:
Log output if restarting MM:
I dont even see the weather module loading in the log-File? But to be honest, i didnt compeared if it was listed before the update in the log... Unfortunatly i didnt stored any older log files.
The Display shows endless "loading". Can someone have a look on this or maybe guide me into deeper analysis?
The text was updated successfully, but these errors were encountered: