You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Just like Mario Kart 7 when the v1.2 update dropped, some mods (like texts) applied using LayeredFS didn't work because the update used a specific file path.
I noticed that the game "The Legend of Dark Witch 2" also has the same issue
The fix would be something like this (in sysmodules/loader/source/patcher.c, this is Starlight3DS, the lines won't really match but this is the same thing for this issue anyways):
This fixes the issue, I can make a pull request, but it would be better to find something else that doing hacky fix for specific games
Update: after some testing, swaping "ro2:" and "rom2:" in the array didn't work, so it's not a false positive, but it didn't get detected at all
The text was updated successfully, but these errors were encountered:
So, after discussing with @cooolgamer privately, it was realized that the issue is the null byte check before the pattern. Maybe this is to prevent false positives, but it's failing here.
Just like Mario Kart 7 when the v1.2 update dropped, some mods (like texts) applied using LayeredFS didn't work because the update used a specific file path.
I noticed that the game "The Legend of Dark Witch 2" also has the same issue
The fix would be something like this (in sysmodules/loader/source/patcher.c, this is Starlight3DS, the lines won't really match but this is the same thing for this issue anyways):
This fixes the issue, I can make a pull request, but it would be better to find something else that doing hacky fix for specific games
Update: after some testing, swaping "ro2:" and "rom2:" in the array didn't work, so it's not a false positive, but it didn't get detected at all
The text was updated successfully, but these errors were encountered: