Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all doc tests to integration tests #38

Open
Lokathor opened this issue May 11, 2020 · 4 comments
Open

Convert all doc tests to integration tests #38

Lokathor opened this issue May 11, 2020 · 4 comments

Comments

@Lokathor
Copy link
Owner

Currently all the tests are done via doc tests.

This means that most functions have only a single test case.

Particularly for a lot of the macros we probably want tests that check all sorts of edge cases. These should be put into the crate as integration tests (that is, modules in the tests/ folder).

@Lokathor Lokathor added this to the v1.0 milestone May 14, 2020
@Lokathor
Copy link
Owner Author

I'm marking this as "good first issue", but I don't expect people to contribute every single integration test in a single PR.

If you'd like to add even one good set of testing for a macro i'd accept an improvement in this area.

@Soveu
Copy link
Contributor

Soveu commented May 19, 2020

Can I use bytemuck for tests? pod_align_to can be helpful to ensure correct alignment for example when using Vec<f32> as &[f32] and &[m256] slices
This would also test the bytemuck feature

@Lokathor
Copy link
Owner Author

yes that's a good idea.

@Soveu Soveu mentioned this issue May 23, 2020
@Lokathor Lokathor removed this from the v1.0 milestone May 30, 2021
@Lokathor Lokathor changed the title Integration Tests? Convert all doc tests to integration tests May 30, 2021
@Lokathor
Copy link
Owner Author

update: yeah the more i do this the more you can see the speed gains within the test suite.

it's boring, but certainly a nice to have. I can continue to convert one module over at a time when i've got an extra boring weekend day or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants