Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add score viewing & PDF download #16

Open
Barmarel opened this issue Jun 20, 2022 · 3 comments
Open

Add score viewing & PDF download #16

Barmarel opened this issue Jun 20, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@Barmarel
Copy link

Please add to the android app:

  • Ability to preview sheet music
  • ability to download in pdf
@PeterNjeim
Copy link
Member

PeterNjeim commented Jun 23, 2022

Please note that the features of the app are not platform-dependent, there is no "Android app", just "the app".

"Previewing" sheet music is accomplished in two ways, either by downloading the MSCZ, then viewing it in a program (usually the MuseScore desktop program), or by downloading the PDF and displaying it as separate pages. It would be unnecessary to implement the previewing feature since you'd be "previewing" a sheet after you've already downloaded it, meaning it's essentially a "postview" at that point. As a result, the thumbnails are the only preview that will be available in the app.

As for PDF downloads, I'll see if I can implement it (note that downloading PDF is always possible via the Userscript, which is available on all platforms, including iOS).

@PeterNjeim PeterNjeim closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2022
@PeterNjeim PeterNjeim added enhancement New feature or request wontfix This will not be worked on labels Jun 23, 2022
@Xmader Xmader reopened this Mar 2, 2023
@Xmader Xmader removed the wontfix This will not be worked on label Mar 2, 2023
@Xmader Xmader changed the title Request functions Add score viewing & PDF download Mar 2, 2023
@matj1
Copy link

matj1 commented Feb 29, 2024

@PeterNjeim Why is downloading PDF available in the userscript and not in the app?

I guess that the app could download the PDF the same way as how the userscript does it.

@PeterNjeim
Copy link
Member

PeterNjeim commented Feb 29, 2024

The userscript has access to the website which is where it downloads the PDF from. The app doesn't, and so either needs a different method, or needs to access the website in the background. I was going to use a similar method used in the command-line tool to download PDF, but the tools available to do it in Flutter (the framework the app uses) were limited, and so I opted not to implement it as it wasn't important as other tools could download it.

As for why not now, two reasons, one, the app has been patched for months now, and two, the command-line tool has also been patched, meaning my preferred method for getting this to work can't work anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants