-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Item Rewards to Events #138
Comments
It would probably require a refactoring of how event data is stored. Since it's scraped, there's no persistent data between events. Each time range is its own object in the database, and none of the information is shared. Which means that even if it was possible to add extra information via the contrib site, it would be thrown away when the event cycle ends and would need to be re-added the next time the event came around. What I could do is separate it into two parts: the event data and an event schedule. Each item in the schedule could relate to an event object, meaning that any manually added event data could be re-used next time the event rolls around. So basically:
{
"id": 1,
"name": "50 Shades of White",
"location": 10,
"zennyReward": 25200,
"rewards": [
{
"id": 1196,
"name": "Fest Ticket",
"...": "..."
}
],
"monsters": [
{
"id": 59,
"name": "Barioth",
"...": "..."
}
],
"exclusive": null,
"questRank": 3,
"masterRank": true,
"timeLimit": 50,
"...": "..."
}
[
{
"id": 174,
"event": {
"id": 1,
"name": "50 Shades of White",
"location": 10,
"zennyReward": 25200,
"rewards": [
{
"id": 1196,
"name": "Fest Ticket",
"...": "..."
}
],
"...": "..."
},
"platform": "pc",
"startTimestamp": "2020-01-17T00:00:00+0000",
"endTimestamp": "2020-02-20T23:59:00+0000"
}
] |
That seems like a good approach to me! |
Actually, thinking through it a bit more, it might be better to add a Here is a starter data set for MHW quests. This can also serve as a way to address other issues that have be filed regarding "item data fluff". |
I think I like that idea a lot more. I had planned on adding quests in the future anyway, and merging the two together would prevent a bunch of duplicate code. |
I think it would be interesting to add a way to include item drops to events in the API. I'm not sure about the implementation details since the information is scraped, but special rewards could certainly be added via the contribution site.
This would make it easier to filter which events give special rewards which can then be linked to what those special items are used to craft.
The text was updated successfully, but these errors were encountered: