Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give a unique URL to each Vinmonopol #12

Open
Vages opened this issue May 2, 2020 · 1 comment
Open

Give a unique URL to each Vinmonopol #12

Vages opened this issue May 2, 2020 · 1 comment

Comments

@Vages
Copy link

Vages commented May 2, 2020

As a user, I would like each Vinmonopol to have a unique URL within Winmonopolet in order to …

  • … bookmark the Vinmonopol and access it more quickly
  • … send a URL to someone to help them navigate the page more quickly
  • … reload the page if some technical error occurred

I also subconsciously appreciate pages that load more quickly, so if page renders and navigation became quicker as a side effect of unique URLs, I would not complain.

Suggested solution

Use some kind of routing package, like react-router or nextjs to handle page routing. Of these two, the issue reporter thinks that nextjs would be the better pick. As hinted at in the problem description, users (and web search crawlers) like pre-fetched links and server-side rendered pages, so the chosen routing solution should enable this.

Future improvements that affect current implementation

A possible future improvement for the page could be storing the display filters (preferred beer types, price range) as query parameters of the URL. To keep the number of changed lines small in this first commit, "filters as query parameters" should probably be left to a later PR, but the possibility of extending the application this way should be kept in mind when choosing the routing package.

@neslekkim
Copy link

And also include category, like so: https://winmonopolet.com/storo/sourbeer (should be human readable, not number/codes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants