Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation from 8 to 4 #8

Open
rohansingh9001 opened this issue Oct 12, 2023 · 5 comments · May be fixed by #29
Open

Fix indentation from 8 to 4 #8

rohansingh9001 opened this issue Oct 12, 2023 · 5 comments · May be fixed by #29
Assignees
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@rohansingh9001
Copy link
Collaborator

Currently, in a lot of our GoLang files, the default indentation is set at 8, we need to set it at 4.

Make sure the code compiles and does everything before pushing.

@rohansingh9001 rohansingh9001 added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 12, 2023
@Ishwarya-Selvaraj
Copy link

Ishwarya-Selvaraj commented Oct 12, 2023

Isn't it about the configuration that we set for the code editors? like in VSC we can edit the tab size to maximise and minimise. @rohansingh9001

Edit: if that is the expected thing, I can pick this up

@rohansingh9001
Copy link
Collaborator Author

Isn't it about the configuration that we set for the code editors? like in VSC we can edit the tab size to maximize and minimise. @rohansingh9001

This is a standard chore job. Currently, a lot of our code has tabs for indentation which looks as 8 spaces in GitHub's editor and some other places.

As best practice, we would like each tab to be replaced by 4 spaces.

@Ishwarya-Selvaraj
Copy link

Okay understood, then I will take this up and modify tabs width to 4 in all files

@rohansingh9001
Copy link
Collaborator Author

Sure go ahead

@Ishwarya-Selvaraj
Copy link

Hi @rohansingh9001 Please review and merge the PR and please add Hactoberfest accepted label as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants