-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't generate helm releases with '+' in the version. #22561
Comments
There was also a mistake in the branch name, fixed it in 34f0332 I guess we should hold back Koenkk/zigbee2mqtt.io#2738 for now? |
I don't think is a problem with the cadence of releases that you have (I don't think we well need to release hot fixes). Imo is fine, I'm just tracking the issue here, and let you know. I think we can merge Koenkk/zigbee2mqtt.io#2743 as soon as the release is done and I've done some testing to validate. |
If possible, I'd do a PR to enable the workflow release of the helm chart via "click" on the UI and ask you to trigger it if you are up to it. |
@jlpedrosa can you check if the chart is published, then I can merge Koenkk/zigbee2mqtt.io#2743 |
This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days |
What happened?
This is just a heads up. The current version of helm releases fails to run the helm release chart process if the version contains a '+' simbol (which is a valid sem versioning).
I tracked down the problem an open a PR to fix it, they don't seem very responsive: helm/chart-releaser#406
Charts with '-' symbols work ok in the interim.
What did you expect to happen?
Not a zigbee2mqtt issue.
How to reproduce it (minimal and precise)
Not a zigbee2mqtt issue.
Zigbee2MQTT version
1.37.0
Adapter firmware version
20230507
Adapter
any
Setup
any
Debug log
NA
The text was updated successfully, but these errors were encountered: