Not all achievements are being granted when conditions are met

[ZimGil]

This is a general issue in version 1 which should be fixed in the refactor planned in version 2

So there are 2 achievements that I should have got which I didn't

• The first was Don't Yell at Me ([ACHIEVEMENT] Dont yell at me #60) that I should have received from merging [ACHIEVEMENT] IM THE DEVIL I LOVE METAL #189

  Unit tested and approved that achievement should have been granted.

• The second was Cutting Edges (Feature/achievement cutting edge #171) that I should have received for merging Server action log ZimGil/ngWiz#88

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[thatkookooguy]

@ZimGil those are two different potential bugs :-)

You shouldn't have got Cutting Edge on ZimGil/ngWiz#88 because that achievement is not in production yet. It's merged to the development branch but wasn't merged into the master branch yet.
Currently, the production branch of achievibit is being deployed from develop manually and that didn't happen since Cutting Edges was merged.

For Don't Yell at Me, that's a real bug!
The entire system will be replaced in version 2, which will probably solve this error so I wouldn't waste too much time on fixing version 1. But if you want to investigate this and fix it in this version, go ahead!
Basically the achievements will pass as is to version 2, but the system that grants them and collects the data is going to get a makeover

I'll change this into a generic issue which will be fixed after the base of version 2 will be deployed