You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While dealing with an unrelated issue (wrong schema version) I came across a crash that occurs when the <sampler2D> tag is specified without an enclosed <instance_image>.
The bug appears to be in LibraryEffectsLoader::fillSamplerArray. If validSurface is false, samplerArray[samplerIndex] is never assigned, and contains uninitialized memory. This is referenced later on from DocumentImporter::writeEffect which is where the crash occurs. Probably one way to avoid this would be to just treat an invalid surface as a fatal error, or some other fallback.
The text was updated successfully, but these errors were encountered:
While dealing with an unrelated issue (wrong schema version) I came across a crash that occurs when the
<sampler2D>tag is specified without an enclosed<instance_image>.The bug appears to be in
LibraryEffectsLoader::fillSamplerArray. IfvalidSurfaceis false,samplerArray[samplerIndex]is never assigned, and contains uninitialized memory. This is referenced later on fromDocumentImporter::writeEffectwhich is where the crash occurs. Probably one way to avoid this would be to just treat an invalid surface as a fatal error, or some other fallback.The text was updated successfully, but these errors were encountered: