Use a single context type #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are lots of speed gains, but still some ways to go.
|
I am not gonna merge this, there's not enough benefit to lose features for, especially the specific method mocks. I think that might still be possible, but it'll take some thinking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleMock is becoming truly simple. Filters are gone, as are specific method mocks.
The code is now 500x more simple.
Closes #10
Closes #6, according to some benchmark runs.
Closes #7, keyword arguments work flawlessly as far as I can tell.
Unfortunately, it's still basically as slow as it ever was, so I'm not sure if I want to merge this. Even though the overdubs are always compiled for the same context, new compilation still happens for every different method you call in your mock block. So it's only fast if you're always calling the same functions within the mock block.