-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serializing Large LRUs hangs/StackOverflows #45
Comments
I think the linked lists will indeed need custom serialisation, as otherwise probably the standard approach tries to traverse from every node down as if they were all infinitely deep trees of independent nodes. |
@Jutho would you be interested in a PR? |
Sure, why not. We have so far not had the need to serialize LRUs, but other people might need it, and so might we at some point. |
Submitted a PR, #46. Let me know what you think. |
The following code hangs on my machine and performs a stackoverflow on another:
I think this is because when there are too many linked nodes, the stack overflows before all the nodes can be serialized. I'm going to be writing some custom serialization logic to handle large LRUs, was wondering if upstream might want the changes.
The text was updated successfully, but these errors were encountered: