Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fragment type checking system for Autocomplete #825

Open
JohnnyMorganz opened this issue Nov 10, 2024 · 1 comment · May be fixed by #841
Open

Use fragment type checking system for Autocomplete #825

JohnnyMorganz opened this issue Nov 10, 2024 · 1 comment · May be fixed by #841
Labels
enhancement New feature or request performance Performance issues with the language server

Comments

@JohnnyMorganz
Copy link
Owner

We can use the incremental type checking API for various different operations:

  • Autocomplete (built into Luau at FragmentAutocomplete)
  • Hover
  • SignatureHelp
  • SemanticTokens (? - depends if it provides a window to register tokens for)
  • InlayHints (? - depends if it provides a window to show hints for)

TODO: check other operations too
@JohnnyMorganz JohnnyMorganz added enhancement New feature or request performance Performance issues with the language server labels Nov 10, 2024
@checkraisefold checkraisefold linked a pull request Nov 22, 2024 that will close this issue
Draft
@JohnnyMorganz
Copy link
Owner Author

Note, this isn't an incremental typechecker, but a fragment based typechecker - the result gets discarded after computation and is not saved.

It might not make sense to use this for all operations then, but scope it down to autocomplete for now.

@JohnnyMorganz JohnnyMorganz changed the title Use incremental type checking system for operations (Autocomplete, Hover, SignatureHelp, etc.) Use fragment type checking system for Autocomplete Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request performance Performance issues with the language server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use new fragment typecheck/autocompletion APIs checkraisefold/luau-lsp
1 participant
@JohnnyMorganz