Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

element_text margin support for dictionary #1265

Open
concimuscb opened this issue Dec 18, 2024 · 2 comments
Open

element_text margin support for dictionary #1265

concimuscb opened this issue Dec 18, 2024 · 2 comments

Comments

@concimuscb
Copy link

Currently element_text supports numbers and lists for parameters.

Numbers make sense but the list implementation is quite confusing in my opinion. Support for a dictionary that takes "top", "bottom", "left", "right" and/or "t", "b", "l", "r" as keys and a number as a value would be a very clean implementation.

@alshan
Copy link
Collaborator

alshan commented Jan 13, 2025

Thank you, this might be a good suggestion.
The current implementation however follows an established pattern from CSS in web development, where margins can be specified using either a single value or a list following the top-right-bottom-left order.
So, I'm not quite sure about dictionary-based margins at the moment.

@concimuscb
Copy link
Author

It is a very minor thing.

I am just opening issues for suggestions but at the end of the day the library is at an amazing spot so even with most of these ideas being unfeasible it would still be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants