Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to include or exclude cross-referenced entries when copying via the "Copy To" menu #12340

Open
HoussemNasri opened this issue Dec 29, 2024 · 7 comments
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@HoussemNasri
Copy link
Member

HoussemNasri commented Dec 29, 2024

Depends on #12339

Why?

https://discourse.jabref.org/t/seamless-crossreferencing/100

How?

When the user copies an entry via the "Copy to" menu, show a dialog with the following options:

  • Copy entry only.
  • Copy associated/cross-referenced entries.
  • Cancel

Copy entry only

  • Will copy that entry ignoring any entries it references.

Copy associated/cross-referenced entries

  • Runs a single copy operation of the target entry and the entries it references

Cancel

  • Close dialog

Regarding cite key clashes: If an entry with the same cite key is already found in the destination library:

  • a) the user has auto generation of citation keys activated -> This would work after copying. I think similar to importing.
  • b) no auto generation: we skip it and show a warning at the end (e.g. in a "Result dialog" like done for copying of BibTeX strings)

Definition of Done

Unit tests for the new dialog (via its view model)

@priyanshu16095
Copy link

I am working on issue #12340, but issues #12339 and #12338 are its parent issues.
Could you please assign this issue to me?

Copy link
Contributor

github-actions bot commented Jan 3, 2025

👋 Hey @priyanshu16095, it looks like you're interested in working on this issue! 🎉

If you'd like to take on this issue, please use the command /assign-me to assign yourself.

@priyanshu16095
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

👋 Hey @priyanshu16095, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 90 days (by 03 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@leaf-soba
Copy link
Contributor

leaf-soba commented Jan 3, 2025

I am working on issue #12340, but issues #12339 and #12338 are its parent issues. Could you please assign this issue to me?

I think you mean the issue 12338, not the PR 12338?

Copy link
Contributor

github-actions bot commented Jan 3, 2025

👋 Hey @leaf-soba, it looks like you're interested in working on this issue! 🎉

If you'd like to take on this issue, please use the command /assign-me to assign yourself.

@priyanshu16095
Copy link

priyanshu16095 commented Jan 3, 2025

@leaf-soba Sorry, not issue #12338; it's #12341 instead.

@HoussemNasri HoussemNasri mentioned this issue Jan 12, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Status: Free to take
Development

No branches or pull requests

3 participants