Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parcel Registry: Data Issues concerning removed parcels #4

Open
ArneD opened this issue Nov 9, 2020 · 2 comments
Open

Parcel Registry: Data Issues concerning removed parcels #4

ArneD opened this issue Nov 9, 2020 · 2 comments
Assignees
Labels
bug Something isn't working parcel Things related to the parcel registry.

Comments

@ArneD
Copy link
Member

ArneD commented Nov 9, 2020

Concerning issue(s): GRAR-1475

Data CRAB

image

The third record in the history table shows eindbewerking = 4 which is a delete.
Then the fourth shows beginbewerking = 1 which is an insert, so after delete there is an insert.
Note: there is no insert at the start, which is because the capakey format changed, the original capakey had an insert record.

Events

image

At StreamVersion 7 event ParcelWasRemoved is applied. But there are CRAB events applied afterwards. Which should not be possible. However, this was only fixed since Informatievlaanderen/parcel-registry@e4c2a5b#diff-597a3c9bce8b7cf275bb4dac462812af52bfa3aca52a7e7ce4cd1613dd2c8e5eR34-R35

On 31/08/2020 fix (1475) was applied. (Informatievlaanderen/parcel-registry@b1264a7)

Problem

Now a new record for this parcel comes in. But the IsRemoved check makes it crash.

Solution

First, we need an answer if the behavior of reinserting a removed parcel is valid.
If so, we'll need to change our code to allow reviving parcels.

After discussion it is possible, however very unlikely, that a parcel is restored.
We'll need to change our code so.

  • If a remove from CRAB is followed by an insert we recover the parcel.
  • We need to create a new event that encapsulates this.
  • Update projections / sync projections to handle this new event.
  • We do NOT reapply linked addresses, will have to come via CRAB.
  • Since some parcels should've been restored already, we'll need to create a fix command and send it to the import api for the related parcels.
@ArneD ArneD added the bug Something isn't working label Nov 9, 2020
@CumpsD CumpsD added the parcel Things related to the parcel registry. label Nov 9, 2020
@ArneD
Copy link
Member Author

ArneD commented Nov 17, 2020

Since some parcels should've been restored already, we'll need to create a fix command and send it to the import api for the related parcels.

Parcel-Address link also has to be touched in CRAB for it to come through again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parcel Things related to the parcel registry.
Projects
None yet
Development

No branches or pull requests

2 participants