Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use features only available since PHP 7.3 #126

Closed
yhabteab opened this issue Sep 25, 2023 · 4 comments · Fixed by #232
Closed

Don't use features only available since PHP 7.3 #126

yhabteab opened this issue Sep 25, 2023 · 4 comments · Fixed by #232
Assignees
@sukhwinder33445

Comments

@yhabteab
Copy link
Member

I noticed in several places where array_key_last() is used, which is available since PHP 7.3.

icinga-notifications-web/application/forms/EscalationRecipientForm.php

Line 227 in e6b64c5

$key = array_key_last($this->options);

icinga-notifications-web/application/forms/EscalationConditionForm.php

Line 260 in e6b64c5

$key = array_key_last($this->options);

icinga-notifications-web/library/Notifications/Widget/EventRuleConfig.php

Line 86 in e6b64c5

$newPosition = (int) array_key_last($escalations) + 1;

@yhabteab yhabteab changed the title Don't use features only available sind PHP 7.3 Don't use features only available since PHP 7.3 Sep 25, 2023
@nilmerg
Copy link
Member

nilmerg commented Sep 26, 2023

Or we consider changing the minimum requirement. To my knowledge, no distribution we support still uses PHP 7.2

@Al2Klimov
Copy link
Member

PHP
Debian 11 7.4
Ubuntu 20.04 7.4
SLES 12.5 7.4
RHEL 8 7.2*

* https://git.icinga.com/packages/icingaweb/-/jobs/534638

@nilmerg
Copy link
Member

nilmerg commented Jul 16, 2024

Well, seems we have to support 7.2 still.

@nilmerg nilmerg linked a pull request Jul 16, 2024 that will close this issue
Replace functions that are not available in php72 #232
Merged
@Al2Klimov
Copy link
Member

@lippserd FWIW:

PHP
Debian x, 11/12 7.4/8.2
Ubuntu x.04, 20/22/24 7.4/8.1/8.3
SLES 12.5 7.4
openSUSE 15.x, 3/4/5/6 7.4/8/8/8.2
Rocky x, 8/9 7.2/8
Amazon Linux It's complicated 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sukhwinder33445 sukhwinder33445

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace functions that are not available in php72 Icinga/icinga-notifications-web
4 participants
@Al2Klimov @nilmerg @sukhwinder33445 @yhabteab