Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't find the use of $certAccountContact or $this->certAccountContact #8

Open
kezenwa opened this issue Mar 25, 2021 · 4 comments
Open

Comments

@kezenwa
Copy link

kezenwa commented Mar 25, 2021

Like the title goes, went through the code but couldn't find where exactly the data contained in $this->certAccountContact is being used.

Care to show me please ?

Thanks

@HLeithner
Copy link
Collaborator

You are right it's not used only checked if it's changed... I will fix this later today... It should be used in line 390...

@kezenwa
Copy link
Author

kezenwa commented Mar 25, 2021

You are right it's not used only checked if it's changed... I will fix this later today... It should be used in line 390...

Okay

Also these 2 methods getEcParameters() and getDhParameters(), both contains a particular PHP inbuilt function proc_open and proc_close both of which mostly are disabled in some hosting servers.

I run my own servers so don't have much issue but I equally have few clients who use shared hostings where these things are not available, anyway to have them replaced.

Took a look at another library / class () and saw they didn't use those 2 functions yet were able to offer same functionality.

Also about $certDistinguishedName array, is it possible to add more information to it and if yes, what sort of information. Just asking anyway.

Thanks for the good work

@kezenwa
Copy link
Author

kezenwa commented Mar 25, 2021

Forgot to ask, the methods getEcParameters() and getDhParameters() both outputs a .pem data .

what kinda data is that ?

I know it's written to a single file but what's it compose of ?

Maybe a private and public key or what ?

Asking because am doing some modifications and needed more insights and a .pem file can contain just about any data. Need be sure I understands that before doing any changes.

Thanks and sorry for the disturbance

@kezenwa
Copy link
Author

kezenwa commented Mar 25, 2021

You are right it's not used only checked if it's changed... I will fix this later today... It should be used in line 390...

Just fixed this in my own version but fortunately, can't share since it's now part of another framework and highly modified.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants