Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long Input Entries Cause Potential Performance and UI Issues #574

Open
ofahimIQSS opened this issue Dec 20, 2024 · 2 comments
Open

Long Input Entries Cause Potential Performance and UI Issues #574

ofahimIQSS opened this issue Dec 20, 2024 · 2 comments
Labels
bug Something isn't working GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA

Comments

@ofahimIQSS
Copy link
Contributor

Description:
While testing the related pull request locally, an issue was observed with the "Registration" page when users enter an excessively long input in the Affiliation and Position fields. The long inputs could potentially cause performance issues, as well as degrade the user experience.

Steps to Reproduce:
Follow the test steps in the pull request.
Navigate to the Registration page using the test account credentials:
Email: [email protected]
Password: curator
In the Affiliation field, enter a very long entry (e.g., "Harvard University") and repeat/paste it multiple times to create a string of 1,000+ characters.
In the Position field, enter a very long entry (e.g., "Affiliate") and repeat/paste it multiple times to create a string of 1,000+ characters.
Click on Create Account.

Observed Behavior:
The form processes the inputs, but there is no restriction on the character length for these fields.
This may lead to performance bottlenecks or unexpected UI behavior.

Expected Behavior:
The input fields should have a sensible character limit to prevent performance and usability issues.

Questions for Discussion:
Should we impose a maximum character limit on the Affiliation and Position fields?
If so, what should the limit be (e.g., 255 characters)?

Suggested Fix:
Add input validation to both Affiliation and Position fields to enforce a character limit.
Implement server-side validation to ensure data integrity in case of API misuse.

@pdurbin
Copy link
Member

pdurbin commented Dec 20, 2024

I'm just adding the nice screenshot from #558 (comment)

397825576-c304e317-e1bd-4dae-9d97-363eb8349324

@g-saracca g-saracca added GREI Re-arch GREI re-architecture-related SPA labels Jan 15, 2025
@g-saracca
Copy link
Contributor

g-saracca commented Jan 15, 2025

@GPortas we will probably need a dataverse repo issue for this also right?

@g-saracca g-saracca added bug Something isn't working Size: 3 A percentage of a sprint. 2.1 hours. Original size: 3 labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA
Projects
Status: No status
Development

No branches or pull requests

3 participants