Fix batch determination different forms issue #4304
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: hypha/apply/determinations/views.py
Did you find this useful? React with a 👍 or 👎 |
hypha/apply/funds/views_all.py
Outdated
| ) | ||
| if redirect: | ||
| return HttpResponseClientRedirect(redirect.url) | ||
| # should redirect |
There was a problem hiding this comment.
Moved should_redirect method directly in here to avoid raising an Error, instead showing the error to the user without performing the batch action.
It is hard to find all the cases at once so I guess it is a better way to avoid 500. We can include the cases to validation as soon as it is reported.
frjo
added
Type: Bug
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
frjo
force-pushed
the
fix/gh-4290-batch-determination-issue
branch
from
7aea2b5 to
3744288
Compare
frjo
force-pushed
the
fix/gh-4290-batch-determination-issue
branch
from
d5ea79a to
5743656
Compare
| @@ -317,6 +320,13 @@ def sub_menu_update_status(request: HttpRequest) -> HttpResponse: | |||
| else [] | |||
| ) | |||
|
|
|||
| # hide determination actions if submissions have different forms | |||
| if not allow_determination: | |||
| determination_actions = ["Dismiss", "Request More Information", "Accept"] | |||
There was a problem hiding this comment.
@sandeepsajan0 Will this work with translations?
frjo
added
Status: Needs testing
|
In testing this definitely was a lot smoother! @sandeepsajan0 I noticed when I selected a couple of lab submissions they all gave me the option to bulk dismiss, and the same with when I selected fund submissions, but combining them removed that option - is this because of the difference in determination forms? if so I think this is ready |
Fixes #4290
Test Steps