Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge application and project communication tabs #4249

Open
frjo opened this issue Dec 5, 2024 · 2 comments · May be fixed by #4349
Open

Merge application and project communication tabs #4249

frjo opened this issue Dec 5, 2024 · 2 comments · May be fixed by #4349
Assignees
@wes-otf
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).

Comments

@frjo
Copy link
Member

frjo commented Dec 5, 2024

They already use the same backend for rendering. The main issue to solve is to make sure we maintain the same visibility rules.

Different user roles should continue to see the same comments as now even when all communication is in a single tab.
@frjo frjo added the Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). label Dec 5, 2024
@wes-otf
Copy link
Contributor

wes-otf commented Jan 2, 2025

has anyone started work on this yet? I can take a stab at it if not

@frjo
Copy link
Member Author

frjo commented Jan 2, 2025

Please go ahead. Would be good to get this issues fixed.

@wes-otf wes-otf self-assigned this Jan 3, 2025
@wes-otf wes-otf linked a pull request Jan 17, 2025 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wes-otf wes-otf

Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Merge application and project communication tabs HyphaApp/hypha
2 participants
@frjo @wes-otf