Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ›’πŸ›οΈπŸ–€ Testing appreciated for upcoming release 1.12.0 #267

Closed
Huluti opened this issue Nov 29, 2024 · 5 comments
Closed
Labels
help wanted Extra attention is needed release
Milestone

Comments

@Huluti
Copy link
Owner

Huluti commented Nov 29, 2024

In order to have a good release I need some help of the translators to update their translations (on Damned Lies) and ideally, it would be nice if some people test the new version from the source code to detect possible bugs.

What to test:

  • Compressing images of all types (PNG, JPG, WebP and SVG) in both safe and non-safe mode and check if any regression can be found
  • Compressing the same image several times in non-safe mode to see the new "Skipped" label with its tooltip
  • Testing the new "Open Image" and "Show in Folder" actions by right-clicking a result line

Changes since 1.11.1:

@Huluti Huluti added help wanted Extra attention is needed release labels Nov 29, 2024
@Huluti Huluti added this to the 1.12.0 milestone Nov 29, 2024
@Huluti
Copy link
Owner Author

Huluti commented Nov 29, 2024

@ARAKHN1D all your work has been merged! Thanks again. If you have some time to do some tests besides me, it would be wonderful to have a good version :)

@ARAKHN1D
Copy link
Contributor

ARAKHN1D commented Nov 29, 2024

Of course! I had some time to do some testing, here are the results:

  • Compressing PNG, JPG, and WebP files all worked for me in both safe and non-safe mode. Compressing SVGs always failed. I think this is a regression, I'm able to compress my testing file on the current stable release.
  • JPG files don't always get skipped, leading to the output being larger. This is due to the -f flag in the compressor, I made a PR that removes them (Don't add --force flag to JPG compressionΒ #268).
  • The skipped label appears correctly when files are skipped. This appears in both safe and non-safe mode, and appears whenever file compression was skipped by Curtail or the compressor.
  • The Open Image and Show in Folder actions work. If you've already navigated to where the image is and click show in folder, the action does nothing.

@Huluti
Copy link
Owner Author

Huluti commented Nov 29, 2024

Thanks a lot for your help again.

  • For SVG can you check if scour has been installed in your build from the About -> Debugging dialog?
  • Good catch for JPGs!
  • All right so!
  • All right so!

@ARAKHN1D
Copy link
Contributor

Hm, it said version not found. That's probably the issue then :P

It also said no version found for pngquant. I tried seeing if I could update my dependencies rebuild to get them working, but it didn't work. I'll have to look into this later. At least this seems like it's just an issue on my system, though we'll have to test on another to confirm.

@Huluti
Copy link
Owner Author

Huluti commented Jan 5, 2025

1.12.0 released!

@Huluti Huluti closed this as completed Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed release
Projects
None yet
Development

No branches or pull requests

2 participants